meta: actually upgrade version during meta migration

It wasn't updated previously leading to attempts to upgrade the DB on every
start. Which then leads to

    error        shard/control.go:17        metabase failure, switching mode        {"shard_id": "XxhmeQZZRSQfDGfiCYo9mB", "stage": "init", "mode": "READ_ONLY", "error": "migrating from 2 to 3 version failed, consider database resync: graveyard value with unexpected 72 length"}

on 0.44.0/0.44.1.

Signed-off-by: Roman Khimov <[email protected]>

pkg/local_object_storage/metabase/version.go

@@ -21,7 +21,10 @@ var versionKey = []byte("version")
 var ErrOutdatedVersion = logicerr.New("invalid version, resynchronization is required")
 
 func (db *DB) checkVersion(tx *bbolt.Tx) error {
-	var knownVersion bool
+	var (
+		knownVersion bool
+		migrated     bool
+	)
 
 	b := tx.Bucket(shardInfoBucket)
 	if b != nil {
@@ -40,11 +43,12 @@ func (db *DB) checkVersion(tx *bbolt.Tx) error {
 				if err != nil {
 					return fmt.Errorf("migrating from %d to %d version failed, consider database resync: %w", stored, version, err)
 				}
+				migrated = true
 			}
 		}
 	}
 
-	if !db.initialized {
+	if !db.initialized || migrated {
 		// new database, write version
 		return updateVersion(tx, version)
 	} else if !knownVersion {

pkg/local_object_storage/metabase/version_test.go

@@ -332,4 +332,11 @@ func TestMigrate2to3(t *testing.T) {
 		})
 	})
 	require.NoError(t, err)
+	err = db.boltDB.View(func(tx *bbolt.Tx) error {
+		if getVersion(tx) != version {
+			return errors.New("version was not updated")
+		}
+		return nil
+	})
+	require.NoError(t, err)
 }