Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RPC Client's Waiter functionality for auto-deploy procedure #444

Open
AnnaShaleva opened this issue Jul 10, 2023 · 0 comments
Open

Use RPC Client's Waiter functionality for auto-deploy procedure #444

AnnaShaleva opened this issue Jul 10, 2023 · 0 comments
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

Current auto-deploy scheme sends notary requests with contracts deploy/update code and doesn't wait until main/fallback are accepted to chain. There are for ; ; prm.monitor.waitForNextBlock(ctx) loops that are used to track the consequenses of the contract deploy/update.

Describe the solution you'd like

I consider that we can safely get rid of for ; ; prm.monitor.waitForNextBlock(ctx) loops, create cancellable context, subscribe for Management's Deploy/Update notifications and use waiter.Wait to wait for either main or fallback. Cancellable context may be used to cancel waiter in case if contract update happens earlier on behalf of some other notary request. I think that with Waiter this code will be clearer. There's a prototype, but it can be improved as described above: 34b1944f7bdfb4f8c8fe8831499d57483ee9ff52.

The same approach can be applied to the simple GAS transfer transactions that increase notary balance for auto-deploy procedure participants.

@AnnaShaleva AnnaShaleva added enhancement Improving existing functionality discussion Open discussion of some problem labels Jul 10, 2023
@roman-khimov roman-khimov added U4 Nothing urgent S2 Regular significance I4 No visible changes and removed discussion Open discussion of some problem labels Dec 21, 2023
@roman-khimov roman-khimov transferred this issue from nspcc-dev/neofs-node Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes S2 Regular significance U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants