Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating actor for shared deploy TX #418

Open
carpawell opened this issue Jul 15, 2024 · 0 comments
Open

Fix creating actor for shared deploy TX #418

carpawell opened this issue Jul 15, 2024 · 0 comments
Labels
bug Something isn't working I4 No visible changes S4 Routine U2 Seriously planned
Milestone

Comments

@carpawell
Copy link
Member

There was a bug with reading the shared transaction, signing it, and changing signer in the original actor: #417.

Current Behavior

It was hotfixed.

Expected Behavior

A correct actor with a correct original sender should be created first. It should be rechecked and checked if there are other places with incorrect actor usage.

Possible Solution

Use a signer from the shared TX. Check that signature is correct and deploy passes.

@carpawell carpawell added bug Something isn't working U2 Seriously planned labels Jul 15, 2024
@roman-khimov roman-khimov added S4 Routine I4 No visible changes labels Jul 16, 2024
@roman-khimov roman-khimov added this to the v0.20.0 milestone Jul 16, 2024
@roman-khimov roman-khimov modified the milestones: v0.20.0, v0.21.0 Jul 29, 2024
@roman-khimov roman-khimov modified the milestones: v0.21.0, v0.22.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes S4 Routine U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants