Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single layer of messages #395

Open
cthulhu-rider opened this issue Apr 21, 2022 · 1 comment
Open

Use single layer of messages #395

cthulhu-rider opened this issue Apr 21, 2022 · 1 comment
Labels
enhancement Improving existing functionality I4 No visible changes S1 Highly significant U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

In current implementation we have 2 layers of messages:

  • so-called v2 layer with types providing stable marshaling
  • grpc layer with auto-generated types

After #389 generated messages provide stable marshaling, so we can purge v2 layer on type-level.

We also need to adopt rpc functionality.

@cthulhu-rider cthulhu-rider added triage I4 No visible changes U4 Nothing urgent and removed triage labels Apr 21, 2022
@fyrchik
Copy link
Contributor

fyrchik commented Jun 30, 2022

  1. This way we could lose the benefit from our previous optimizations Get rid of the overhead use of pointers in field setters and repeated fields #376 .
  2. Because now SDK uses v2 aliases in many places, we would need to implement similar wrappers in SDK. They can be more optimal there, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I4 No visible changes S1 Highly significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants