Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockFetcher/BlockUploader: fix and add additional attributes #3637

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3631

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 83.27%. Comparing base (e82d9a1) to head (c47d4e6).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/uploader.go 0.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3637      +/-   ##
==========================================
- Coverage   83.32%   83.27%   -0.06%     
==========================================
  Files         334      334              
  Lines       46446    46464      +18     
==========================================
- Hits        38703    38691      -12     
- Misses       6165     6205      +40     
+ Partials     1578     1568      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AnnaShaleva
AnnaShaleva previously approved these changes Oct 22, 2024
cli/util/uploader.go Outdated Show resolved Hide resolved
cli/util/uploader.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva dismissed their stale review October 22, 2024 11:07

Approved by accident, changes are required.

@AliceInHunterland AliceInHunterland force-pushed the attributes branch 2 times, most recently from 35d103b to bc8e52e Compare October 22, 2024 14:58
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I'm not merging this PR without a final full-cycle uploader/downloader test. The test should be done after #3628 and #3624 resolution, hence waiting for dependent PRs to be merged.

cli/util/uploader.go Outdated Show resolved Hide resolved
cli/util/uploader.go Outdated Show resolved Hide resolved
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

cli/util/uploader.go Outdated Show resolved Hide resolved
AnnaShaleva
AnnaShaleva previously approved these changes Oct 23, 2024
@AnnaShaleva AnnaShaleva dismissed their stale review October 23, 2024 08:50

Tests are failing.

@AnnaShaleva
Copy link
Member

2024-10-23T08:34:53.2882722Z failed to load account: open wallet: open ./not-exist.json: no such file or directory
2024-10-23T08:34:53.2883695Z failed to decode container ID: invalid length 3
2024-10-23T08:34:53.2885040Z failed to create RPC client: failed to get network magic: Post "https://test": dial tcp: lookup test on 127.0.0.53:53: server misbehaving
2024-10-23T08:34:53.2887105Z     logger.go:146: 2024-10-23T08:34:47.157Z	DEBUG	processing rpc request	{"method": "getversion", "params": "[]"}
2024-10-23T08:34:53.2889593Z     logger.go:146: 2024-10-23T08:34:47.157Z	DEBUG	processing rpc request	{"method": "getnativecontracts", "params": "[]"}
2024-10-23T08:34:53.2892126Z     logger.go:146: 2024-10-23T08:34:47.242Z	DEBUG	done processing headers	{"headerIndex": 2, "blockHeight": 1, "took": "167.934µs"}
2024-10-23T08:34:53.2894727Z     logger.go:146: 2024-10-23T08:34:47.343Z	DEBUG	done processing headers	{"headerIndex": 3, "blockHeight": 2, "took": "175.388µs"}
2024-10-23T08:34:53.2896538Z failed to dial NeoFS pool: at least one node must be healthy
2024-10-23T08:34:53.2897437Z     executor.go:239: 
2024-10-23T08:34:53.2898879Z         	Error Trace:	/home/runner/work/neo-go/neo-go/internal/testcli/executor.go:239
2024-10-23T08:34:53.2901236Z         	            				/home/runner/work/neo-go/neo-go/internal/testcli/executor.go:244
2024-10-23T08:34:53.2903266Z         	            				/home/runner/work/neo-go/neo-go/cli/util/util_test.go:212
2024-10-23T08:34:53.2904473Z         	Error:      	Received unexpected error:
2024-10-23T08:34:53.2905309Z         	            	EOF
2024-10-23T08:34:53.2905991Z         	Test:       	TestUploadBin
2024-10-23T08:34:53.2907547Z     logger.go:146: 2024-10-23T08:34:47.380Z	INFO	shutting down RPC server	{"endpoint": "127.0.0.1:40959"}
2024-10-23T08:34:53.2910442Z     logger.go:146: 2024-10-23T08:34:47.380Z	INFO	persisted to disk	{"blocks": 3, "keys": 163, "headerHeight": 3, "blockHeight": 3, "took": "68.588µs"}
2024-10-23T08:34:53.2912386Z --- FAIL: TestUploadBin (0.24s)
2024-10-23T08:34:53.2912861Z FAIL

Capitalize block objects and index file objects attributes.
Add network magic attribute to container.

Close #3631

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AnnaShaleva AnnaShaleva merged commit 0b79901 into master Oct 23, 2024
33 of 35 checks passed
@AnnaShaleva AnnaShaleva deleted the attributes branch October 23, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve NeoFS BlockFetcher/BlockUploader object attributes
3 participants