can we make comply.checkMethod public?

[ixje]

I have a use-case in which I want to check if a contract has a subset of the required NEP-17 methods. This function seems to do 99% of what I'm looking for but 1. it's not exposed, could this be exposed?

neo-go/pkg/smartcontract/manifest/standard/comply.go

Lines 107 to 108 in 4e6ce9c

	func checkMethod(m *manifest.Manifest, expected *manifest.Method,
	allowMissing bool, checkNames bool) error {

2. could we add an option to skip safe checking? I have a case where the contract wrongly specifies the safe flag but it still functions correctly. In a great world this contract would have been rejected during deploy, but we all know why that isn't there so I'm hoping to work around it without too much code duplication.

[roman-khimov]

1. Probably, but maybe what you really want is a flag for ComplyABI?
2. I love links, so Compliance checks for manifested standards neo-project/neo#1883, yeah. But this flag feels like a bad idea to me. What's the problem there? Something that should be safe is not marked as safe?

[ixje]

1. For now that would cover my use-case as I think I can create my own standard to cherry pick what methods I care about. 2. Exactly. Something not marked safe that should be e.g nep-17 “symbol()” On 8 Jan 2023, at 14:50, Roman Khimov ***@***.***> wrote: Probably, but maybe what you really want is a flag for ComplyABI? I love links, so neo-project/neo#1883, yeah. But this flag feels like a bad idea to me. What's the problem there? Something that should be safe is not marked as safe? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>