Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go #25

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Upgrade Go #25

merged 3 commits into from
Aug 9, 2024

Conversation

roman-khimov
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (9aa6026) to head (ea14835).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files           1        1           
  Lines          47       47           
=======================================
  Hits           39       39           
  Misses          6        6           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i commend that u mentioned policy switch in commit text nspcc-dev/tzhash@fd980ce cuz strictly speaking 1.21 grade and 2version support are separate changes. Suggest todo the same here

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit has changes that were made in two commits in another PR. Just a note.

@roman-khimov
Copy link
Member Author

Suggest todo the same here

Makes sense.

The last commit has changes that were made in two commits in another PR. Just a note.

That was deliberate, when you're repeating things they need less explanations.

Fixes #13. Notice that `slices` can't be reused effectively here because of
the way `sliceToSort.Swap` works, it manages two slices at once.

Update workflows to drop 1.20 as well, follow new versioning policy, see
nspcc-dev/.github#30.

Signed-off-by: Roman Khimov <[email protected]>
Follow nspcc-dev/neo-go#3511, use newer syntax and
defaults.

Signed-off-by: Roman Khimov <[email protected]>
@roman-khimov roman-khimov merged commit 2c17f72 into master Aug 9, 2024
11 checks passed
@roman-khimov roman-khimov deleted the up-go branch August 9, 2024 11:35
@carpawell
Copy link
Member

That was deliberate, when you're repeating things they need less explanations.

We are writing commit history not to recall it in minutes but to keep it for years. It is a little bit ridiculous that we are discussing this in such a petty PR but I have to say that I was surprised when I saw the same things are done differently, that is my concern in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants