-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Go #25
Upgrade Go #25
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 1 1
Lines 47 47
=======================================
Hits 39 39
Misses 6 6
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i commend that u mentioned policy switch in commit text nspcc-dev/tzhash@fd980ce cuz strictly speaking 1.21 grade and 2version support are separate changes. Suggest todo the same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit has changes that were made in two commits in another PR. Just a note.
Makes sense.
That was deliberate, when you're repeating things they need less explanations. |
Fixes #13. Notice that `slices` can't be reused effectively here because of the way `sliceToSort.Swap` works, it manages two slices at once. Update workflows to drop 1.20 as well, follow new versioning policy, see nspcc-dev/.github#30. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Follow nspcc-dev/neo-go#3511, use newer syntax and defaults. Signed-off-by: Roman Khimov <[email protected]>
We are writing commit history not to recall it in minutes but to keep it for years. It is a little bit ridiculous that we are discussing this in such a petty PR but I have to say that I was surprised when I saw the same things are done differently, that is my concern in general. |
No description provided.