Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates needed to clarify open() behavior and concept-id usage #846

Open
asteiker opened this issue Oct 22, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@asteiker
Copy link
Member

This feedback came from @trevorlang :

  1. I think it would be nice to explicitly state that .open() will automatically select based on the environment the code is executing in here. It kind of says it, just not as explicitly as I would like to feel confident. In addition, it might be useful to document somewhere how it is picking which links to use and what happens if s3 links dont exist. Not sure if it states it somewhere else that I just missed. I wouldve liked to had seen it in the API docs for .open() though.

  2. concept_id was not mentioned as a parameter for .search_data here and it just happened to work when I tried. Unless that was on purpose and I should avoid using the granule concept id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant