-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests for affected apps only #416
Comments
Add support for affected:test that works similar to the e2e target except it runs test instead. Theoretically useful for a CI process to run the unit tests based on the apps affected by the change. This is WIP towards Issue nrwl#416
I pushed my WIP so you can see the direction I was going with this. It seemed like a simple change at first but then led me down a rabbit hole of small changes I had to make for the tests until finally running into the mentioned message that made me stop and rethink it entirely. I am assuming you left this feature out for a philosophical reason of some kind? |
It's tricky to make this functionality work in CLI 1.x, which is what the current version of Nx is using. It's easier to make it work with CLI6, which provides more extension points. We are currently working on changing Nx to use CLI6, which should fix this issue. |
This functionality has been implemented in Nx 6. |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
I started working on a PR to add support for affected:test. It is getting a bit bigger than I expected and I might be over my head now. But what has happened is I have run into this:
This leads me to believe the lack of support for this feature was intentional. Is that true? If so, why? We are building out a monorepo with several apps in it and we wanted to setup our CI process to only run the tests for the app affected by the commit. We already do this nicely for the e2e tests.
Should I just abandon this idea?
The text was updated successfully, but these errors were encountered: