Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(misc): add initial speaker post #27715

Merged
merged 1 commit into from
Aug 30, 2024
Merged

docs(misc): add initial speaker post #27715

merged 1 commit into from
Aug 30, 2024

Conversation

mhartington
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@mhartington mhartington requested a review from a team as a code owner August 30, 2024 15:47
Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Aug 30, 2024 5:22pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but headers should be Title Case

@isaacplmann
Copy link
Collaborator

I think it would also look better if you had the individual speaker's profile photos next to their talk description

@isaacplmann isaacplmann merged commit 18e5535 into master Aug 30, 2024
6 checks passed
@isaacplmann isaacplmann deleted the blog-mw-speakers branch August 30, 2024 17:43
FrozenPandaz pushed a commit that referenced this pull request Sep 3, 2024
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 18e5535)
Copy link

github-actions bot commented Sep 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants