Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook enhancement: Include @storybook/core/types #3894

Closed
mandarini opened this issue Oct 9, 2020 · 3 comments
Closed

Storybook enhancement: Include @storybook/core/types #3894

mandarini opened this issue Oct 9, 2020 · 3 comments
Assignees
Labels
outdated scope: storybook Issues related to Storybook support in Nx stale type: enhancement

Comments

@mandarini
Copy link
Member

Description

Storybook config files could be written in TypeScript, and that could help include the @storybook/core/types as well, which is quite beneficial for ts users.

Motivation

This is a low priority, but adding it here after discussing with @yannbf. It would give people better typing support even in config files.

Suggested Implementation

Use the --js flag to determine whether people want the Js or Ts files, and if they want the Ts files, then use a new configuration.

@mandarini mandarini added type: feature type: enhancement scope: storybook Issues related to Storybook support in Nx labels Oct 9, 2020
@mandarini mandarini self-assigned this Oct 9, 2020
@mandarini
Copy link
Member Author

mandarini commented Oct 9, 2020

@yannbf I created this issue, to track potential enhancements! Let's keep this open and discuss how we can move forward.

@github-actions
Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: storybook Issues related to Storybook support in Nx stale type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant