0.9.1 migration removes "lazyLoad"

[ph55]

When updating from 0.8.0 to 0.9.1 - "lazyLoad" block removed from "nx-enforce-module-boundaries".
I assume it's related to new feature - support for tagged libs

[skydever]

I found out that there is an autodetection for that now.

I got it like that: the rule checks lib dependencies, also if a lib is loaded via loadChildren into another lib/app. if so, imports from that lazy loaded lib into the lib/app that is lazy loading via loadChildren are not allowed. no need to keep track of it manually anymore, and it allows you to do both (lazy and not lazy) including the lazy only check if the lib is supposed to be lazy loaded, awesome!

e.g. my-app is using loadChildren to load my-lib. imports within my-app from @myworkspace/my-lib produce a lint error in that case: imports of lazy-loaded libraries are forbidden. my-app-two can import @myworkspace/my-lib (it does not use loadChildren for my-lib), even if my-app is using loadChildren.

[skydever]

...but this is still required at the corresponding tsconfig.app.json I suppose (e.g. in my-app when using loadChildren):

"include": [
    "**/*.ts"
    /* add all lazy-loaded libraries here: "../../../libs/my-lib/index.ts" */,
    "../../../libs/my-lib/index.ts"
  ]

... maybe a nice additional feature, to show a lint error at the line of loadChildren if the typescript setup is missing that in it's include, to get the error when you type it ...

[ph55]

I found out that there is an autodetection for that now

I don't think so.

This is with module added to "lazyLoad" (correct validation)

---

This is without module in "lazyLoad" (no validation)

[skydever]

you are sure that you are on 0.9.1, maybe a lint cache problem in your ide? see 56788ba

... or you only upgraded @nrwl/nx? the lint rule is part of @nrwl/schematics (You must use the same version of the two packages) ...

[ph55]

I see. Both @nrwl/nx and @nrwl/schematics are 0.9.1
Did reinstall node_modues

rm -rf node_modules package-lock.json
npm install

Now I see circular dependencies warnings (tslint) which tells it's updated.
But, lazy load warnings stopped to work at all.

[ph55]

Closing in favor of #352

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.