Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): add background on pricing tiles & blog link to pricing page #27157 #27157

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

ndcunningham
Copy link
Contributor

No description provided.

@ndcunningham ndcunningham requested a review from a team as a code owner July 26, 2024 16:58
@ndcunningham ndcunningham requested a review from isaacplmann July 26, 2024 16:58
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Jul 26, 2024 5:38pm

@bcabanes bcabanes changed the title fix(nx-dev): Pricing css and blog link to pricing page fix(nx-dev): add background on pricing tiles & blog link to pricing page Jul 26, 2024
@bcabanes bcabanes changed the title fix(nx-dev): add background on pricing tiles & blog link to pricing page fix(nx-dev): add background on pricing tiles & blog link to pricing page #27157 Jul 26, 2024
@bcabanes bcabanes enabled auto-merge (squash) July 26, 2024 17:02
@isaacplmann
Copy link
Collaborator

The pipeline failure is a problem with the link checker script, not an actual broken link. I'm working on fixing the script now.

@isaacplmann
Copy link
Collaborator

I updated the link checker in this PR instead

@ndcunningham
Copy link
Contributor Author

I updated the link checker in this PR instead

@isaacplmann
It looks like when we define a navigation to any page that is inside nx-dev/app/ with a # included it will cause the checker to fail. Is it possible to improve this in another PR without ignoring the routes?

@isaacplmann
Copy link
Collaborator

Yes, definitely possible to make the link checker smarter. We used to not have very many hand-coded pages, so it wasn't as important. Now that nx.app pages are merged in, it matters more.

@bcabanes bcabanes merged commit 04fb62d into master Jul 26, 2024
6 checks passed
@bcabanes bcabanes deleted the fix/pricing-plans-blog-update branch July 26, 2024 17:43
FrozenPandaz pushed a commit that referenced this pull request Jul 29, 2024
FrozenPandaz pushed a commit that referenced this pull request Jul 30, 2024
Copy link

github-actions bot commented Aug 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants