-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated package.json file missing dependencies since 19.1.2 #26410
Comments
Also seeing this here on 19.2.0 after upgrading from 19.0.0 tRPC is missing from our API, which is weird since it's imported in many places and never conditionally - also sort of the most important dependency for our API!
|
We see the same problem. @trpc/server and mimetext are missing. As a temporary workaround we are specifying these dependencies in the app's package.json. |
@Nick-Lucas could you see what version of I think this repo showcases the same @trpc/server depenency missing but I'm not sure. @meeroslav can you take a look please? |
Now I think of it here's a diff of everything which changed between 19.0.0 and 19.2.0 the react and react-query stuff also appears to have been correctly there originally since we use the @trpc/react-query package for some TS type imports in the API and it would all get dragged in if Nx isn't filtering |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
Versions 19.1.2 and 19.2.0 appear to have introduced some regression whereby the generated package.json file is missing some dependencies.
Expected Behavior
Generated package.json file is not missing dependencies.
GitHub Repo
No response
Steps to Reproduce
Really quite difficult to create a minimal reproduction since this is happening in a monorepo with 20 apps and dozens of dependencies.
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
Configuration from one of our build targets.
"build": { "executor": "@nx/webpack:webpack", "outputs": ["{options.outputPath}"], "options": { "target": "node", "compiler": "tsc", "outputPath": "dist/apps/commercial/destination/site-admin-api", "main": "apps/commercial/destination/site-admin-api/src/main.ts", "tsConfig": "apps/commercial/destination/site-admin-api/tsconfig.app.json", "tsPlugins": ["@nestjs/swagger/plugin"], "webpackConfig": "apps/commercial/destination/site-admin-api/webpack.config.js", "generatePackageJson": true },
The text was updated successfully, but these errors were encountered: