Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook run command terminates right after it successfully ran message #26087

Closed
1 of 4 tasks
NechiK opened this issue May 26, 2024 · 4 comments
Closed
1 of 4 tasks
Assignees
Labels
outdated scope: storybook Issues related to Storybook support in Nx type: bug

Comments

@NechiK
Copy link

NechiK commented May 26, 2024

Current Behavior

After updating to Storybook 8, when I run the command npx nx storybook angular-test-storybook, it builds stories and opens the browser, so I can see that modules are building, BUT it terminates right after the message Successfully ran target storybook for project angular-test-storybook. It worked when I initially created the NX workspace and used Storybook 7.

Expected Behavior

The command npx nx storybook angular-test-storybook should start watch mode as it was with Storybook 7.

P.S. I've tested Storybook 8 on a clean Angular environment (without NX), and it works properly.

GitHub Repo

https://github.com/NechiK/nx-angular-storybook-8-issue

Steps to Reproduce

  1. Create Nx workspace npx create-nx-workspace@latest angular-test-storybook --preset=angular-monorepo
  2. Run npx nx add @nx/storybook
  3. Add configuration npx nx g @nx/angular:storybook-configuration angular-test-storybook
  4. Run storybook npx nx storybook angular-test-storybook. It runs successfully, and I can view it in the browser.
  5. Upgrade to Storybook 8 npx storybook@latest upgrade --config-dir apps/angular-test-storybook/.storybook
  6. Re-run the storybook: npx nx storybook angular-test-storybook. It runs a build, shows the Storybook version message with URLs, and Successfully ran target storybook for project angular-test-storybook. And immediately terminates.

Nx Report

NX   Report complete - copy this into the issue template

Node   : 18.20.2
OS     : darwin-x64
npm    : 10.5.0

nx                 : 19.1.0
@nx/js             : 19.1.0
@nx/jest           : 19.1.0
@nx/linter         : 19.1.0
@nx/eslint         : 19.1.0
@nx/workspace      : 19.1.0
@nx/angular        : 19.1.0
@nx/cypress        : 19.1.0
@nx/devkit         : 19.1.0
@nx/eslint-plugin  : 19.1.0
@nx/storybook      : 19.1.0
@nrwl/tao          : 19.1.0
@nx/web            : 19.1.0
@nx/webpack        : 19.1.0
typescript         : 5.4.5
---------------------------------------
Registered Plugins:
@nx/storybook/plugin
---------------------------------------
Community plugins:
@storybook/angular : 8.1.3

Failure Logs

No failure logs

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

I had this issue when I used Nx 19.0.6 and 19.0.8 versions too.

@ryandegruyter
Copy link

I had the same issue, check this out: storybookjs/storybook#27355

@FrozenPandaz FrozenPandaz added the scope: storybook Issues related to Storybook support in Nx label May 27, 2024
@rhutchison
Copy link
Contributor

@NechiK
Copy link
Author

NechiK commented May 27, 2024

Thanks @ryandegruyter

They have fixed it in 8.1.4 release today.

@NechiK NechiK closed this as completed May 27, 2024
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: storybook Issues related to Storybook support in Nx type: bug
Projects
None yet
Development

No branches or pull requests

5 participants