-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17.2 broke our MFE remotes with all remotes on same port #20974
Comments
This is blocking us from updating to 17.2 or higher. Any suggestions? |
This is a general problem with the new static-serve and mfe regardless of framework. We are using react and are currently also running into this problem, because we can no longer route to the correct module. (static vs devRemotes) |
@rbirkgit in the
This then forces the correct port to be pulled as defined in the nx/packages/react/src/executors/module-federation-dev-server/module-federation-dev-server.impl.ts Line 277 in 11e139c
@leosvelperez is this intentional (did the jump from 16.4.2)? |
@smasala That will start the remotes in devRemote mode. That has not been an issue. The problem is when starting them in static mode (which is much faster), the ports are all the same. Then switching to devMode (if you need to debug a remote), it will not use the same port number. |
This also does not work for projects with dynamic module federation, as the app has no way of knowing if the remote is served via static or devRemote, making it impossible to load the remoteEntry file. |
This isssue is still present in 19.0.0 |
With 18.2.4+ the old behavior magically came back, with each remote on separate ports. I should have mentioned it. Tested 19.0 and it works fine there and still using separate ports. |
Closed as fixed, thanks for raising the issue! |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
With 17.2 all remotes now start on the same port when in static mode, but on different ports when in dev mode. This breaks our env and we can no longer update to 17.2 or higher.
Expected Behavior
We expect a revert of this feature of having all remotes on same port, or an easy way to go back to how it was with 17.1.
GitHub Repo
No response
Steps to Reproduce
Have a repo with MFE remotes and update to 17.2
Nx Report
Failure Logs
No response
Package Manager Version
No response
Operating System
Additional Information
In our hosts proxy config file we have this but cannot figure out how to support different port numbers/path depending on static or dev mode and why we need the static ports remain on different ports, i.e. same as in dev mode.
The text was updated successfully, but these errors were encountered: