Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(devkit): update parseTargetString to allow referencing targets on the current project #19109

Conversation

AgentEnder
Copy link
Member

Current Behavior

When an executor takes a buildTarget option, it frequently is a target on the current project. Currently, folks must reference the full target string, starting with the project. This means that the option is filled in with something like: my-project:build, even inside of my-project's project.json file.

Expected Behavior

When filling in parameters with a buildTarget or similar fields, you can omit the project name if referencing a target on the same project.

Note

This PR only updates the helper - follow up PRs will be required for each plugin to pass in the executor context instead of the graph.

@AgentEnder AgentEnder requested review from a team as code owners September 11, 2023 15:17
@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 3:55pm

@FrozenPandaz FrozenPandaz merged commit 2283937 into nrwl:master Sep 11, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants