Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue): add private Vue plugin #19009

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 5, 2023

This PR adds an empty vue plugin to start adding generators and executors to. It is marked as private for now so we don't publish until it is feature complete. The usual targets are setup (lint, test, build).

Also adds CODEOWNERS entry for Vue. For now it is the JS maintainers since Katerina, Nicholas, and myself are the same people working on Vue. We can change that later if needed.

@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2023 2:12pm

{
"name": "@nx/vue",
"version": "0.0.1",
"private": true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent @nx/vue from being published (except to local registry).

@jaysoo jaysoo force-pushed the feat/vite-plugin branch 2 times, most recently from 64d6beb to 33751e7 Compare September 5, 2023 17:55
CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments all related to Angular CLI config

packages/vue/package.json Outdated Show resolved Hide resolved
packages/vue/package.json Outdated Show resolved Hide resolved
packages/vue/package.json Outdated Show resolved Hide resolved
packages/vue/executors.json Outdated Show resolved Hide resolved
@jaysoo jaysoo force-pushed the feat/vite-plugin branch 2 times, most recently from db4ec16 to 7086a8c Compare September 5, 2023 18:27
tsconfig.base.json Outdated Show resolved Hide resolved
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two minor notes

@mandarini mandarini merged commit f3fb455 into nrwl:master Sep 6, 2023
@jaysoo jaysoo deleted the feat/vite-plugin branch September 6, 2023 18:13
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants