Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): improve link text for ai docs #18943

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Aug 31, 2023

Create a longer_heading option to be used in case of duplicate sources heading.

  • Use longer_heading if heading is null
  • Use longer_heading if heading is duplicate
  • Stop when AI starts generating ### Sources of its own.

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 4:58pm

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the variable casing is consistent. So url_partial should be urlPartial or partialUrl. Otherwise LGTM.

@mandarini
Copy link
Member Author

@jaysoo I think it is consistent. Did I miss something? I am using snake case for Supabase column names.

@mandarini mandarini merged commit 1931390 into nrwl:master Sep 1, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants