Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nx-dev): move all the querying logic to edge function #18834

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat(nx-dev): move all the querying logic to edge function #18834

merged 2 commits into from
Aug 31, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Aug 25, 2023 •
edited
Loading

TODO:

  • Need to fix error handling. Now all errors show as 500. Need to propagate the message
  • Make sure all works as expected
  • Move Supabase feedback requests to another edge function
  • Remove Supabase feedback requests
  • Implement streaming
  • Add the warning box
  • Add the sources
  • Temporarily disable moderation to see if results are faster

Test here

@mandarini mandarini self-assigned this Aug 25, 2023
@vercel
Copy link

vercel bot commented Aug 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 0:43am

@nx-cloud
Copy link

nx-cloud bot commented Aug 25, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3b39925. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@mandarini mandarini force-pushed the feat/move-ai-to-edge branch 3 times, most recently from 0f65af1 to 4079f20 Compare August 25, 2023 09:35
@mandarini mandarini force-pushed the feat/move-ai-to-edge branch 2 times, most recently from cea5f33 to 45a584f Compare August 28, 2023 15:26
@mandarini mandarini marked this pull request as ready for review August 28, 2023 15:27
@mandarini mandarini requested review from a team, AgentEnder and jaysoo as code owners August 29, 2023 12:23
@mandarini mandarini force-pushed the feat/move-ai-to-edge branch 2 times, most recently from fded87e to 341fc5e Compare August 30, 2023 13:38
jaysoo
jaysoo reviewed Aug 30, 2023
View reviewed changes
nx-dev/nx-dev/pages/api/query-ai-handler.ts Outdated Show resolved Hide resolved
nx-dev/nx-dev/pages/api/query-ai-handler.ts Outdated Show resolved Hide resolved
nx-dev/nx-dev/pages/api/query-ai-handler.ts Outdated Show resolved Hide resolved
@mandarini mandarini force-pushed the feat/move-ai-to-edge branch 2 times, most recently from 6c90160 to a285673 Compare August 30, 2023 16:56
@mandarini mandarini force-pushed the feat/move-ai-to-edge branch 2 times, most recently from 288a6f3 to 05c8cd8 Compare August 30, 2023 17:24
@mandarini mandarini requested a review from jaysoo August 30, 2023 17:27
jaysoo
jaysoo approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment otherwise LGTM

FrozenPandaz
FrozenPandaz approved these changes Aug 31, 2023
View reviewed changes
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@FrozenPandaz FrozenPandaz merged commit 1abe35c into nrwl:master Aug 31, 2023
3 checks passed
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@isaacplmann isaacplmann isaacplmann approved these changes

@jaysoo jaysoo jaysoo approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner

Assignees

@mandarini mandarini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandarini @jaysoo @isaacplmann @FrozenPandaz @barbados-clemens