Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): support incremental building when running 'serve' #18797

Conversation

barbados-clemens
Copy link
Contributor

closed #18458

Current Behavior

when using incremental building with vite buildLibsFromSource: false, vite would still reference the source code when running 'serve'.

Expected Behavior

incremental building works with serve as well as build.

Note: serve will need to depend on '^build' in order for it to work without manually building first.

Related Issue(s)

Fixes #18458

@barbados-clemens barbados-clemens added the scope: bundlers Issues related to webpack, rollup label Aug 23, 2023
@barbados-clemens barbados-clemens self-assigned this Aug 23, 2023
@barbados-clemens barbados-clemens requested a review from a team as a code owner August 23, 2023 18:38
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 6:44pm

@barbados-clemens barbados-clemens merged commit 14506d2 into nrwl:master Aug 24, 2023
4 checks passed
@barbados-clemens barbados-clemens deleted the fix/incremental-vite-target-name branch August 24, 2023 13:46
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: bundlers Issues related to webpack, rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildLibsFromSource: false doesn't work with Vite dev-server executor
2 participants