Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): enable analyzeSourceFile as needed when generating new lint project #18769

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Aug 22, 2023

This PR ensures that JS sources are analyzed when generating a new project that requires package.json lint checks.

Current Behavior

Users coming from package-based repos (e.g. nx.json extends nx/presets/npm.json), then adding a JS lib will not be able to use the @nx/dependency-checks lint rule. This is because we don't pick up dependencies from JS source files.

Expected Behavior

When adding a new project that uses @nx/dependency-checks lint rule, we should enable source file analysis.

Related Issue(s)

Fixes #18704

@jaysoo jaysoo requested a review from a team as a code owner August 22, 2023 13:37
@jaysoo jaysoo requested a review from meeroslav August 22, 2023 13:37
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 24, 2023 11:44am

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor suggestion but otherwise looks good to me

@jaysoo jaysoo merged commit 4846ae5 into nrwl:master Aug 24, 2023
3 checks passed
@jaysoo jaysoo deleted the issue/18704 branch August 24, 2023 13:37
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/dependency-checks doesn't find dependencies used by library
2 participants