-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): enable analyzeSourceFile as needed when generating new lint project #18769
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one minor suggestion but otherwise looks good to me
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR ensures that JS sources are analyzed when generating a new project that requires
package.json
lint checks.Current Behavior
Users coming from package-based repos (e.g.
nx.json
extendsnx/presets/npm.json
), then adding a JS lib will not be able to use the@nx/dependency-checks
lint rule. This is because we don't pick up dependencies from JS source files.Expected Behavior
When adding a new project that uses
@nx/dependency-checks
lint rule, we should enable source file analysis.Related Issue(s)
Fixes #18704