fix(core): do not use joinPathFragments for generating files #18753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Cammisuli
force-pushed
the
fix_windows_drive_letters_for_cnw
branch
from
7549766
to
62d529a
Compare
Cammisuli
changed the title
Cammisuli
force-pushed
the
fix_windows_drive_letters_for_cnw
branch
from
62d529a
to
44de0ff
Compare
Cammisuli
requested review from
meeroslav,
mandarini,
barbados-clemens and
leosvelperez
barbados-clemens
approved these changes
Aug 22, 2023
Cammisuli
force-pushed
the
fix_windows_drive_letters_for_cnw
branch
from
44de0ff
to
b4c121b
Compare
leosvelperez
approved these changes
Aug 22, 2023
4 tasks
Cammisuli
force-pushed
the
fix_windows_drive_letters_for_cnw
branch
from
b4c121b
to
41f003e
Compare
AgentEnder
reviewed
Aug 22, 2023
| @@ -5,14 +5,16 @@ function removeWindowsDriveLetter(osSpecificPath: string): string { | |||
| } | |||
|
|
|||
| /** | |||
| * Coverts an os specific path to a unix style path | |||
| * Coverts an os specific path to a unix style path. Use this when writing paths to config files. | |||
| * This should not be used to read files on disk because of the removal of Windows drive letters. | |||
There was a problem hiding this comment.
This messaging will show up on nx.dev as well as intellisense for devkit users, I think its probably fine as-is, but maybe it'd be worth phrasing it more in line with it being ok for relative paths but not absolute? I can't think of a time that it wouldn't work when given relative path args.
AgentEnder
approved these changes
Aug 22, 2023
mandarini
approved these changes
Aug 23, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running
npx create-nx-workspaceon a drive that is notC:, the process fails because we strip out the drive letter before trying to gather file information. This failure happens duringcreate-nx-workspaceandensurePackagebecause those two functions will create a temporary directory (usually in%LOCALAPPDATA%, ie -C:\Users\user\AppData\Local), and run nx generators from there. If we try to usereaddirSyncwithout the drive letter, it will default to looking at the current working directory. So if the working directory isD:\dev, and a generator file is inC:\Users\user\AppData\Local\etc, Nx will "normalize" the windows path and remove the drive letter, and node will try to look for the file inD:\Users\user\AppData\Local\etc.Expected Behavior
Generating files do not remove the drive letter, and we just use a regular
joinRelated Issue(s)
Fixes #18677
fixes #18727