Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): await prettier format for v3 compatibility #18664

Merged
merged 2 commits into from
Aug 20, 2023

Conversation

Michsior14
Copy link
Contributor

@Michsior14 Michsior14 commented Aug 17, 2023

Current Behavior

Files formatting during migrations execution doesn't write changes properly when running with prettier v3.
This is a continuation of #18644.

Expected Behavior

All generators or internal formatting methods support prettier v3.

Prettier documentation mentions this change in the example of this section.

Related Issue(s)

@Michsior14 Michsior14 requested review from a team as code owners August 17, 2023 00:25
@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2023 4:12pm

@Michsior14
Copy link
Contributor Author

Michsior14 commented Aug 17, 2023

Could anyone restart the build? It looks it failed due to nx cloud timeouts.

EDIT: I've rebased to the latest master to restart it by myself.

@Michsior14
Copy link
Contributor Author

@AgentEnder Any feedback on this? It would greatly improve prettier support during migration execution :)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants