feat(core): support prettier v3 as a formatter

[Michsior14]

Current Behavior

Nx crashes when used with prettier v3.

Expected Behavior

Nx works with all prettier versions up to the newly released v3.

Related Issue(s)

Fixes #17990

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 15, 2023 9:56pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1668419. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• linux nx affected --target=e2e --base=40d66ec715cc23d935130cedac53bf71fb5eecab --head=1668419ce58601f7409f1ff7a057f62edc32bfe3 --parallel=1
• linux nx affected --target=test --base=40d66ec715cc23d935130cedac53bf71fb5eecab --head=1668419ce58601f7409f1ff7a057f62edc32bfe3 --parallel=1
• linux nx affected --target=build --base=40d66ec715cc23d935130cedac53bf71fb5eecab --head=1668419ce58601f7409f1ff7a057f62edc32bfe3 --parallel=3
• linux nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• linux nx affected --target=lint --base=40d66ec715cc23d935130cedac53bf71fb5eecab --head=1668419ce58601f7409f1ff7a057f62edc32bfe3 --parallel=3
• nx-cloud record -- nx format:check --base=40d66ec715cc23d935130cedac53bf71fb5eecab --head=1668419ce58601f7409f1ff7a057f62edc32bfe3
• linux nx documentation --no-dte
• macos nx affected -t e2e-macos --parallel=1 --base=40d66ec715cc23d935130cedac53bf71fb5eecab --head=1668419ce58601f7409f1ff7a057f62edc32bfe3

---

Sent with 💌 from NxCloud.

[AgentEnder]

This is a really good start 🎉, I left one nitpick but it will also likely need to be handled inside packages/devkit/src/generators/format-files.ts

[Michsior14]

This is a really good start tada, I left one nitpick but it will also likely need to be handled inside packages/devkit/src/generators/format-files.ts

Not sure about the format-files.ts file. It should be correctly working with import as it is.

[AgentEnder]

This is a really good start tada, I left one nitpick but it will also likely need to be handled inside packages/devkit/src/generators/format-files.ts

Not sure about the format-files.ts file. It should be correctly working with import as it is.

Hey @Michsior14, typescript will transpile away the dynamic import there, so it would hit the same issue I believe? Could we apply a similar patch there to import prettier.cjs if it is present?

[Michsior14]

This is a really good start tada, I left one nitpick but it will also likely need to be handled inside packages/devkit/src/generators/format-files.ts

Not sure about the format-files.ts file. It should be correctly working with import as it is.

Hey @Michsior14, typescript will transpile away the dynamic import there, so it would hit the same issue I believe? Could we apply a similar patch there to import prettier.cjs if it is present?

But this is a dynamic import of a library not a binary, isn't it? AFAIK the lib entry point stays the same.

[AgentEnder]

Good call, I think you are correct. Thanks for the contribution 🎉

[gioragutt]

@AgentEnder someone shared this PR with me (post merge), my comment would have been not to do heuristics about what the binary is, but instead just make use of PackageJson['bin'], that way it wouldn't break regardless of version.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.