Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): use helper to determine project name and root directory in project generators #18620

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Aug 14, 2023

Updates the Node plugin project generators (application and library) to use the helper to determine the project name and root.

For more context on the changes, see: #18420

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Aug 14, 2023
@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2023 7:17pm

@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from 2c3385a to 6a7a294 Compare August 14, 2023 14:52
@leosvelperez leosvelperez marked this pull request as ready for review August 14, 2023 15:43
@leosvelperez leosvelperez requested review from a team as code owners August 14, 2023 15:43
@leosvelperez leosvelperez marked this pull request as draft August 16, 2023 08:54
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from 6a7a294 to 9f919ee Compare August 17, 2023 09:52
@leosvelperez leosvelperez changed the title feat(node): use helper to determine project name and root directory in library generator feat(node): use helper to determine project name and root directory in project generators Aug 17, 2023
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from 9f919ee to 6f4141d Compare August 17, 2023 15:42
@leosvelperez leosvelperez marked this pull request as ready for review August 17, 2023 15:47
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from 6f4141d to 7526993 Compare August 18, 2023 08:44
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from 7526993 to ca2c5a6 Compare August 18, 2023 09:09
@leosvelperez leosvelperez requested a review from a team as a code owner August 18, 2023 09:09
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from ca2c5a6 to 4972b6e Compare August 18, 2023 12:49
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from 4972b6e to 7fe0166 Compare August 18, 2023 15:21
@leosvelperez leosvelperez force-pushed the node/library-use-name-root-helper branch from e20343d to 381f01d Compare August 21, 2023 07:33
Copy link
Contributor

@ndcunningham ndcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) August 21, 2023 19:26
@FrozenPandaz FrozenPandaz merged commit d566055 into nrwl:master Aug 21, 2023
3 checks passed
@leosvelperez leosvelperez deleted the node/library-use-name-root-helper branch August 22, 2023 07:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants