-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): Normalize paths when in getSourceFilePath #18601
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
FrozenPandaz
pushed a commit
that referenced
this pull request
Aug 18, 2023
Co-authored-by: jgelin <[email protected]> (cherry picked from commit 1f9b3c4)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running the linting rule
@nx/dependency-checks
for a project on a Windows machine, it doesn't fail even if the list of packages is not valid.The
projectPath
provided to the utility functiongetSourceFilePath
inpackages/eslint-plugin/src/utils/runtime-lint-utils.ts
is not normalized:Expected Behavior
The linting rule
@nx/dependency-checks
should work in the same way on Windows or UNIX paths.Fixes
To prevent future issues, I decided to make the
getSourceFilePath
compatible with any type of path instead of fixing the@nx/dependency-checks
code.Tests are covering that utility function
@nx/dependency-checks