Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): fix swc compilation output path handling #18588

Merged
merged 4 commits into from
Aug 11, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Aug 11, 2023
@meeroslav meeroslav requested a review from a team as a code owner August 11, 2023 15:40
@meeroslav meeroslav requested a review from ndcunningham August 11, 2023 15:40
@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 8:43pm

@FrozenPandaz FrozenPandaz merged commit b152f20 into nrwl:master Aug 11, 2023
@ffMathy
Copy link

ffMathy commented Aug 14, 2023

We're still getting an error after this beta release:

Could not find /workspace/dist/src/apps/redacted/src/main.js. Make sure your build succeeded.

@meeroslav meeroslav deleted the fix-swc-compile-again branch August 14, 2023 08:23
@meeroslav
Copy link
Contributor Author

The problem that this PR was fixing wouldn't have resulted in such an error. Can you provide a minimal repo @ffMathy where this can be reproduced?

@ffMathy
Copy link

ffMathy commented Aug 14, 2023

We ended up just switching to esbuild instead, so it's no longer a priority. Not sure why it failed.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants