-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): make the default react playwright test to pass #18559
Merged
xiongemi
merged 1 commit into
nrwl:master
from
xiongemi:bugfix/fix-playwright-default-react-tests
Aug 11, 2023
Merged
fix(testing): make the default react playwright test to pass #18559
xiongemi
merged 1 commit into
nrwl:master
from
xiongemi:bugfix/fix-playwright-default-react-tests
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xiongemi
force-pushed
the
bugfix/fix-playwright-default-react-tests
branch
from
August 10, 2023 04:09
c4fb172
to
b920ba0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments.
packages/playwright/src/generators/configuration/files/playwright.config.ts.template
Outdated
Show resolved
Hide resolved
packages/playwright/src/generators/configuration/files/__directory__/example.spec.ts.template
Outdated
Show resolved
Hide resolved
xiongemi
force-pushed
the
bugfix/fix-playwright-default-react-tests
branch
from
August 10, 2023 17:25
b920ba0
to
d33e930
Compare
barbados-clemens
approved these changes
Aug 10, 2023
xiongemi
force-pushed
the
bugfix/fix-playwright-default-react-tests
branch
from
August 10, 2023 18:41
d33e930
to
96811ca
Compare
xiongemi
force-pushed
the
bugfix/fix-playwright-default-react-tests
branch
from
August 11, 2023 03:41
96811ca
to
c54e6d0
Compare
xiongemi
force-pushed
the
bugfix/fix-playwright-default-react-tests
branch
from
August 11, 2023 05:42
c54e6d0
to
2764456
Compare
4 tasks
4 tasks
ndcunningham
approved these changes
Aug 11, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #