-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): playwright plugin clean up #18447
Merged
barbados-clemens
merged 4 commits into
nrwl:master
from
barbados-clemens:fix/playwright-follow-up
Aug 2, 2023
Merged
fix(testing): playwright plugin clean up #18447
barbados-clemens
merged 4 commits into
nrwl:master
from
barbados-clemens:fix/playwright-follow-up
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbados-clemens
requested review from
FrozenPandaz,
vsavkin and
a team
as code owners
August 2, 2023 17:20
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
Aug 2, 2023
including renaming fns like runCypressTests to runE2ETests
barbados-clemens
force-pushed
the
fix/playwright-follow-up
branch
from
August 2, 2023 17:44
a3b7a4c
to
9bd5e54
Compare
barbados-clemens
requested review from
a team,
meeroslav and
mandarini
as code owners
August 2, 2023 17:44
FrozenPandaz
approved these changes
Aug 2, 2023
xiongemi
approved these changes
Aug 2, 2023
ndcunningham
approved these changes
Aug 2, 2023
isaacplmann
approved these changes
Aug 2, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
TODO:
runCypress
utils to berunE2E
and like env varsRelated Issue(s)
Fixes #