-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-dev): plugin quality indicators #18426
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this not be committed? Could we have a github action generate this and trigger a vercel deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's possible.
The only problem with that is there are a lot of network calls that happen in the script. If something goes wrong on the network, then the live data will be wrong. Committing the results of the script at least gives us a chance to double check that we haven't lost the npm downloads for every package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text on hover is fixed and the Nx Team pill has always been in the right corner. |
@meeroslav I figured out what you meant about the Nx Team pill. I've fixed it so the pill stays in the right corner when it wraps to the next line. |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Adds quality indicators to the plugin registry.
https://nx-dev-git-docs-plugin-registry-nrwl.vercel.app/extending-nx/registry
Now the PR also includes sorting buttons. It seemed like filters weren't necessary once the sorting was available.
This PR is functional as is, but more work is planned in future PRs: