Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix performance of hashing external dependencies up front #18359

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Combining the partial hashes when calculating the external node hashes takes a lot of time.

Expected Behavior

Partial hashes of the external nodes are calculated up front and combined later.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner July 28, 2023 01:27
@FrozenPandaz FrozenPandaz requested a review from vsavkin July 28, 2023 01:27
@vercel
Copy link

vercel bot commented Jul 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2023 3:32pm

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants