-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix performance of hashing external dependencies up front #18359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
force-pushed
the
fix-external-hash-perf
branch
from
July 28, 2023 13:54
0de95dc
to
15f1cab
Compare
FrozenPandaz
force-pushed
the
fix-external-hash-perf
branch
from
July 28, 2023 14:50
15f1cab
to
7b20f15
Compare
FrozenPandaz
force-pushed
the
fix-external-hash-perf
branch
from
July 28, 2023 14:59
7b20f15
to
93fa47b
Compare
FrozenPandaz
force-pushed
the
fix-external-hash-perf
branch
from
July 28, 2023 15:29
93fa47b
to
6d341e0
Compare
Cammisuli
approved these changes
Jul 28, 2023
This was referenced Aug 1, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Combining the partial hashes when calculating the external node hashes takes a lot of time.
Expected Behavior
Partial hashes of the external nodes are calculated up front and combined later.
Related Issue(s)
Fixes #