Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix dep outputs hashing #18331

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Jul 26, 2023

Current Behavior

When tasks depends on outputs of tasks which have a glob as their output, things break.

Expected Behavior

When tasks depends on outputs of tasks which have a glob as their output, it is hashed correctly.

Related Issue(s)

Fixes #

@FrozenPandaz FrozenPandaz requested review from a team as code owners July 26, 2023 19:35
@FrozenPandaz FrozenPandaz requested a review from vsavkin July 26, 2023 19:35
@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 5:16pm

@FrozenPandaz FrozenPandaz force-pushed the fix-output-hashing branch 2 times, most recently from 2ad271f to 460438e Compare July 26, 2023 21:18
@FrozenPandaz FrozenPandaz force-pushed the fix-output-hashing branch 2 times, most recently from 5240483 to 8672913 Compare July 27, 2023 03:30
@FrozenPandaz FrozenPandaz force-pushed the fix-output-hashing branch 2 times, most recently from 4bd4fe9 to 7ec8d16 Compare July 27, 2023 14:19
@Cammisuli Cammisuli self-requested a review July 27, 2023 15:00
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants