Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs): builder should work with pnp #18325

Merged
merged 2 commits into from
Jul 27, 2023
Merged

fix(nextjs): builder should work with pnp #18325

merged 2 commits into from
Jul 27, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Jul 26, 2023
@meeroslav meeroslav requested a review from a team as a code owner July 26, 2023 15:48
@meeroslav meeroslav requested a review from mandarini July 26, 2023 15:48
@vercel
Copy link

vercel bot commented Jul 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2023 1:16pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 26, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 55f917b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@meeroslav meeroslav requested a review from a team as a code owner July 27, 2023 07:29
@meeroslav meeroslav requested a review from Cammisuli July 27, 2023 07:29
@meeroslav meeroslav force-pushed the fix-nextjs-builder branch from fbff723 to 7b95cc3 Compare July 27, 2023 07:30
@meeroslav meeroslav force-pushed the fix-nextjs-builder branch from 7b95cc3 to 25d802e Compare July 27, 2023 08:57
@meeroslav meeroslav requested a review from a team as a code owner July 27, 2023 08:57
@meeroslav meeroslav requested a review from FrozenPandaz July 27, 2023 08:57
@meeroslav meeroslav force-pushed the fix-nextjs-builder branch from 25d802e to aa56c96 Compare July 27, 2023 10:16
@meeroslav meeroslav merged commit 1363bae into nrwl:master Jul 27, 2023
@meeroslav meeroslav deleted the fix-nextjs-builder branch July 27, 2023 13:54
@jaysoo jaysoo mentioned this pull request Jul 28, 2023
Merged
jaysoo added a commit that referenced this pull request Jul 28, 2023
@jaysoo
Revert "fix(nextjs): builder should work with pnp (#18325)"
d8f6060 
This reverts commit 1363bae.
@timonmasberg timonmasberg mentioned this pull request Aug 1, 2023
Merged
This was referenced Aug 1, 2023
Closed
Closed
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@mandarini mandarini Awaiting requested review from mandarini mandarini is a code owner automatically assigned from nrwl/nx-react-reviewers

@Cammisuli Cammisuli Awaiting requested review from Cammisuli Cammisuli was automatically assigned from nrwl/nx-core-reviewers

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz FrozenPandaz was automatically assigned from nrwl/nx-pipelines-reviewers

Assignees

@meeroslav meeroslav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meeroslav @jaysoo