fix(js): ensure compile swc uses current package manager #18321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
commented
Jul 26, 2023
| @@ -42,8 +48,6 @@ export async function compileSwc( | |||
| normalizedOptions: NormalizedSwcExecutorOptions, | |||
| postCompilationCallback: () => Promise<void> | |||
| ) { | |||
| const isRootProject = | |||
meeroslav
force-pushed
the
fix-swc-compile
branch
from
c57c15b to
ed7b8ad
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
ed7b8ad to
cec3b46
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
cec3b46 to
0ae941b
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
0ae941b to
fe6af65
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
fe6af65 to
544a9c2
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
544a9c2 to
6a39df0
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
6a39df0 to
8f961cf
Compare
meeroslav
force-pushed
the
fix-swc-compile
branch
from
8f961cf to
7d57bfe
Compare
jaysoo
approved these changes
Jul 28, 2023
This was referenced Aug 1, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Using Swc compilation on PnP repos fails due to usage of
npxcommand.Expected Behavior
We should use the original package manager when invoking
swcRelated Issue(s)
Fixes #