fix(core): eslint dep check rule should check prereleases correctly #18317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
fix/dependency-check-rule
branch
from
11620bf to
4d28210
Compare
This was referenced Aug 1, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The dep check rule does not check pre-releases correctly
This surfaced with #17879
You can see the error here: https://staging.nx.app/runs/21ueB3TkiN/task/angular%3lint
The package versions are here:
nx/packages/angular/package.json
Line 71 in 4bae74c
Expected Behavior
Pre-release version should be picked up correctly
Related Issue(s)
Fixes #