feat(graph): add more graph to editor communication #18315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxKless
requested review from
philipjfulcher,
FrozenPandaz and
bcabanes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MaxKless
force-pushed
the
open-project-json-console
branch
3 times, most recently
from
33c8cf0 to
a143a3f
Compare
MaxKless
force-pushed
the
open-project-json-console
branch
from
a143a3f to
53c76f7
Compare
MaxKless
changed the title
philipjfulcher
approved these changes
Aug 1, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #18113, this PR introduces two things that are only visible when rendered in Nx Console.
EditbuttonNx Console can consume the events from that button click and open the corresponding
project.jsonfile.I'm not 100% sure about the styles, maybe @bcabanes can weigh in. Alternatively, we could make the project name in the tooltip header clickable (with some hover link styling) but I feel like the button is a lot more discoverable.
So I'm worried that if it's not immediately obvious, noone will use it.
Run Taskbutton on the task tooltipNx Console can consume the events and run the task
Corresponding Nx Console PR: nrwl/nx-console#1841