Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add playwright e2eTestRunner option #18284

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

barbados-clemens
Copy link
Contributor

@barbados-clemens barbados-clemens commented Jul 24, 2023

Note waiting on v16.6.0 release before merging.

Current Behavior

@nx/web only supports cypress as a e2eTestRunner

Expected Behavior

add playwright as a e2eTestRunner option for app and init generators
add e2e tests using playwright
add generator tests for playwright
update ensurePackage to not be awaited since ensurePackage does not need to be awaited

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 2:17pm

@barbados-clemens barbados-clemens merged commit 27923fd into nrwl:master Aug 1, 2023
@barbados-clemens barbados-clemens deleted the feat/web-playwright branch August 1, 2023 15:12
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: misc Misc issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants