-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): add playwright e2eTestRunner option #18284
Merged
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:feat/web-playwright
Aug 1, 2023
Merged
feat(web): add playwright e2eTestRunner option #18284
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:feat/web-playwright
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
feat/web-playwright
branch
from
July 24, 2023 19:20
77a70a0
to
92d8754
Compare
barbados-clemens
force-pushed
the
feat/web-playwright
branch
from
July 24, 2023 19:24
92d8754
to
1270822
Compare
barbados-clemens
force-pushed
the
feat/web-playwright
branch
from
July 24, 2023 20:23
1270822
to
57c9208
Compare
jaysoo
approved these changes
Jul 25, 2023
barbados-clemens
force-pushed
the
feat/web-playwright
branch
from
July 31, 2023 14:15
57c9208
to
61ab27a
Compare
AgentEnder
approved these changes
Aug 1, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/web only supports cypress as a e2eTestRunner
Expected Behavior
add playwright as a e2eTestRunner option for app and init generators
add e2e tests using playwright
add generator tests for playwright
update
ensurePackage
to not be awaited since ensurePackage does not need to be awaitedRelated Issue(s)
Fixes #