Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-dev): fix official plugin badge background #18274

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Jul 24, 2023

https://nx-dev-git-fork-meeroslav-fix-official-nrwl.vercel.app/plugins/registry

Badge now works in both light and dark mode

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Jul 24, 2023
@meeroslav meeroslav requested a review from a team as a code owner July 24, 2023 14:47
@meeroslav meeroslav requested a review from bcabanes July 24, 2023 14:47
@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 2:51pm

@meeroslav meeroslav enabled auto-merge (squash) July 24, 2023 14:48
@meeroslav meeroslav changed the title fix(nx-dev): fix official background fix(nx-dev): fix official plugin badge background Jul 24, 2023
@meeroslav meeroslav disabled auto-merge July 24, 2023 14:50
@meeroslav meeroslav enabled auto-merge (squash) July 24, 2023 14:50
@meeroslav meeroslav requested a review from juristr July 24, 2023 14:52
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it, but I let @bcabanes weight in here as well. Maybe we could have it a little less intense on the dark theme?

@meeroslav meeroslav merged commit cd3472d into nrwl:master Jul 24, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants