@nx/js:node: serve does not terminate if waitUntilTargets are specified

[chromey]

Current Behavior

#17553 re-introduced support for waitUntilTargets after it had been accidentally removed in #17524. However, nx serve is now no longer correctly handling SIGTERM events. When CTRL-C-ing out of the process, it prints

 NX  Process exited with code null, waiting for changes to restart...

and returns to the console, but the process does not terminate, as is evident by re-running nx serve (fails with an EADDRINUSE error).

Expected Behavior

Cancelling nx serve should terminate the watch process and all spawned children.

GitHub Repo

No response

Steps to Reproduce

1. create a new workspace and demo app with the nest preset
2. add a trivial waitUntilTarget using the nx:run-commands executor, e.g.

    "serve": {
      "executor": "@nx/js:node",
      "defaultConfiguration": "development",
      "options": {
        "buildTarget": "demo:build",
        "waitUntilTargets": ["demo:do-stuff"]
      },
      "configurations": {
        "development": {
          "buildTarget": "demo:build:development"
        },
        "production": {
          "buildTarget": "demo:build:production"
        }
      }
    },
    "do-stuff": {
      "executor": "nx:run-commands",
      "options": {
        "command": "ls"
      }
    },

3. Run nx serve, then terminate the process
4. Run nx serve again

Nx Report

Node   : 18.16.0
   OS     : darwin-arm64
   npm    : 9.5.1
   
   nx (global)        : 16.5.3
   nx                 : 16.5.4
   @nx/js             : 16.5.4
   @nx/jest           : 16.5.4
   @nx/linter         : 16.5.4
   @nx/workspace      : 16.5.4
   @nx/devkit         : 16.5.4
   @nx/eslint-plugin  : 16.5.4
   @nx/nest           : 16.5.4
   @nx/node           : 16.5.4
   @nrwl/tao          : 16.5.4
   @nx/webpack        : 16.5.4
   typescript         : 5.1.6

Failure Logs

No response

Operating System

• macOS
• Linux
• Windows
• Other (Please specify)

Additional Information

No response

[chromey]

In the meantime I will move on with using dependsOn as suggested by @jaysoo in #17524, which does not exhibit this problem

[github-actions]

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.