Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(devkit): use Workspace in devkit for backwards compatibility #18246

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix(devkit): use Workspace in devkit for backwards compatibility #18246

merged 1 commit into from
Jul 21, 2023

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 7:26pm

@xiongemi xiongemi marked this pull request as ready for review July 21, 2023 18:54
@xiongemi xiongemi requested a review from a team as a code owner July 21, 2023 18:54
@xiongemi xiongemi requested a review from vsavkin July 21, 2023 18:54
@nx-cloud
Copy link

nx-cloud bot commented Jul 21, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 42e7b34. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@xiongemi xiongemi force-pushed the fix/add-workspaces-nx-backward-compatible branch from 4484e56 to 42e7b34 Compare July 21, 2023 19:23
@xiongemi xiongemi requested review from a team as code owners July 21, 2023 19:23
@xiongemi xiongemi merged commit 2e6592c into nrwl:master Jul 21, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barbados-clemens barbados-clemens barbados-clemens approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@jaysoo jaysoo jaysoo approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner automatically assigned from nrwl/nx-devkit-reviewers

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner automatically assigned from nrwl/nx-linter-reviewers

@mandarini mandarini Awaiting requested review from mandarini mandarini is a code owner automatically assigned from nrwl/nx-js-reviewers

@Coly010 Coly010 Awaiting requested review from Coly010 Coly010 is a code owner automatically assigned from nrwl/nx-angular-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiongemi @jaysoo @FrozenPandaz @barbados-clemens