Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): handle complex glob patterns within rust #18242

Merged
merged 7 commits into from
Jul 25, 2023
Merged

fix(core): handle complex glob patterns within rust #18242

merged 7 commits into from
Jul 25, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Jul 21, 2023 •
edited
Loading

Current Behavior

Output patterns that contain the non-standard unix negate pattern (ie, dir/!(cache)/**/!(README).(md|txt)) do no work correctly

Expected Behavior

These patterns should work as expected, where we manage the globs behind the scenes

Related Issue(s)

Fixes #

@Cammisuli Cammisuli requested review from a team as code owners July 21, 2023 16:01
@Cammisuli Cammisuli requested a review from AgentEnder July 21, 2023 16:01
@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 1:06pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 21, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8fb3932. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@Cammisuli Cammisuli marked this pull request as draft July 21, 2023 16:16
@Cammisuli Cammisuli force-pushed the handle_negated_globs branch from acf89bd to 0f12a18 Compare July 21, 2023 16:45
@Cammisuli Cammisuli force-pushed the handle_negated_globs branch from 0f12a18 to 6f068b8 Compare July 24, 2023 13:41
@Cammisuli Cammisuli marked this pull request as ready for review July 24, 2023 13:42
@Cammisuli Cammisuli requested review from a team, FrozenPandaz and vsavkin as code owners July 24, 2023 13:42
@Cammisuli Cammisuli requested a review from meeroslav July 24, 2023 13:42
@Cammisuli Cammisuli changed the title fix(core): handle negated glob patterns fix(core): handle complex glob patterns for outputs Jul 24, 2023
@Cammisuli Cammisuli changed the title fix(core): handle complex glob patterns for outputs fix(core): handle complex glob patterns within rust Jul 24, 2023
@Cammisuli Cammisuli force-pushed the handle_negated_globs branch from 6f068b8 to 609cc11 Compare July 24, 2023 14:12
@Cammisuli Cammisuli force-pushed the handle_negated_globs branch from 270dc84 to c021468 Compare July 24, 2023 15:28
@FrozenPandaz FrozenPandaz merged commit b6db266 into nrwl:master Jul 25, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner automatically assigned from nrwl/nx-core-reviewers

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@meeroslav meeroslav Awaiting requested review from meeroslav meeroslav is a code owner automatically assigned from nrwl/nx-docs-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cammisuli @FrozenPandaz