Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): make sure skipLibCheck is true #18212

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

mandarini
Copy link
Member

closed #18153

Current Behavior

If you create an Angular app with ng new and then you do nx init in that app, skipLibCheck is not added in root tsconfig.json (or tsconfig.base.json). This results in some type errors when running Storybook.

Expected Behavior

If a user configures Storybook, make sure skipLibCheck is true in their root tsconfig.json.

Related Issue(s)

Fixes #18153

@mandarini mandarini requested a review from a team as a code owner July 20, 2023 10:44
@mandarini mandarini requested a review from Coly010 July 20, 2023 10:44
@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 1:16pm

@mandarini mandarini assigned mandarini and jaysoo and unassigned jaysoo Jul 20, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
@mandarini mandarini deleted the fix/make-sure-skipLibCheck-true branch August 22, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook cannot run in Angular CLI project that has been migrated to Nx
2 participants