-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): add playwright secondary entrypoint for preset #18202
Merged
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/playwright-preset-entrypiont
Jul 20, 2023
Merged
fix(testing): add playwright secondary entrypoint for preset #18202
barbados-clemens
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/playwright-preset-entrypiont
Jul 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
fix/playwright-preset-entrypiont
branch
from
July 19, 2023 20:40
1338ef1
to
b1a7f67
Compare
barbados-clemens
requested review from
FrozenPandaz,
vsavkin and
a team
as code owners
July 19, 2023 20:54
barbados-clemens
force-pushed
the
fix/playwright-preset-entrypiont
branch
from
July 19, 2023 20:56
b1a7f67
to
0726d6a
Compare
barbados-clemens
force-pushed
the
fix/playwright-preset-entrypiont
branch
from
July 19, 2023 21:08
0726d6a
to
aa2c722
Compare
barbados-clemens
changed the title
fix(testing): add preset secondary entrypoint
fix(testing): add playwright secondary entrypoint for preset
Jul 19, 2023
xiongemi
approved these changes
Jul 19, 2023
jaysoo
approved these changes
Jul 20, 2023
FrozenPandaz
approved these changes
Jul 20, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
microsoft/playwright#19798
when importing from @playwright/test, expect is overridden causing issues with global jest expect.
therefore test start failing with
This happens because the playwright e2e preset file imports from @playwright/test; therfore,
importing from the main index.ts causing @playwright/test to be imported into jest program
Expected Behavior
a secondary entrypoint for the playwright preset should be used instead of the main index file.
Related Issue(s)
Fixes #