Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): run playwright from workspaceRoot #18195

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

playwright runs from projectRoot, which results in paths having to be from projectRoot causing extra pathing '../../' for many options.
Also doesn't align with most other executor behaviors defining paths from the workspaceRoot.

Expected Behavior

run playwright from workspaceRoot making pathing align with other executors

Related Issue(s)

Fixes #

@barbados-clemens barbados-clemens requested a review from a team as a code owner July 19, 2023 18:09
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 6:32pm

@barbados-clemens barbados-clemens self-assigned this Jul 19, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jul 19, 2023
@jaysoo jaysoo merged commit 3e86e42 into nrwl:master Jul 19, 2023
@barbados-clemens barbados-clemens deleted the fix/playwright-cwd branch July 19, 2023 18:37
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants