Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): migrate old invalid glob syntax in target outputs #18191

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

Cammisuli
Copy link
Member

Current Behavior

Invalid glob syntax in target outputs do not work (ie. dist/*.(js|map|ts). This was because our older glob utility allowed this.

Expected Behavior

This migrates outputs that have the invalid syntax to dist/*.{js,map,ts}.

Related Issue(s)

Fixes #18075

@Cammisuli Cammisuli requested review from a team as code owners July 19, 2023 15:53
@Cammisuli Cammisuli requested review from vsavkin and juristr July 19, 2023 15:53
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 10:57am

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

16.5.1: outputs glob with extensions stoped working
3 participants