-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): migrate old invalid glob syntax in target outputs #18191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…y in getting outputs
AgentEnder
approved these changes
Jul 19, 2023
FrozenPandaz
requested changes
Jul 19, 2023
packages/nx/src/migrations/update-16-5-4/update-output-globs.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/migrations/update-16-5-4/update-output-globs.ts
Outdated
Show resolved
Hide resolved
packages/nx/src/migrations/update-16-5-4/update-output-globs.ts
Outdated
Show resolved
Hide resolved
Cammisuli
force-pushed
the
update-output-globs
branch
from
July 20, 2023 10:53
4b3f865
to
6eb988d
Compare
FrozenPandaz
approved these changes
Jul 20, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 20, 2023
(cherry picked from commit fef5b65)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Invalid glob syntax in target outputs do not work (ie.
dist/*.(js|map|ts)
. This was because our older glob utility allowed this.Expected Behavior
This migrates outputs that have the invalid syntax to
dist/*.{js,map,ts}
.Related Issue(s)
Fixes #18075