Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): add options for frameworks in playwright configuration… #18190

Merged

Conversation

barbados-clemens
Copy link
Contributor

… generator

Current Behavior

missing QoL improments for playwright plugin to make integration with other generators easier

  • no way to configure web server
  • missing executor outputs
  • isolated test-results directory
  • vscode extension recommendation

Expected Behavior

adding the above

Related Issue(s)

Fixes #

@barbados-clemens barbados-clemens requested a review from a team as a code owner July 19, 2023 15:32
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 19, 2023 3:53pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 74e5481. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@barbados-clemens barbados-clemens force-pushed the fix/playwright-gen-qol branch from d460b0e to f753e6f Compare July 19, 2023 15:43
@barbados-clemens barbados-clemens self-assigned this Jul 19, 2023
@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Jul 19, 2023
@barbados-clemens barbados-clemens enabled auto-merge (squash) July 19, 2023 15:48
@barbados-clemens barbados-clemens force-pushed the fix/playwright-gen-qol branch from f753e6f to 74e5481 Compare July 19, 2023 15:50
@barbados-clemens barbados-clemens merged commit 8d11816 into nrwl:master Jul 19, 2023
@barbados-clemens barbados-clemens deleted the fix/playwright-gen-qol branch July 19, 2023 16:14
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants