feat(angular): add playwright to e2eTestRunner option #18163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
5a4fdda to
391a226
Compare
barbados-clemens
added
scope: testing tools
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
391a226 to
bbeb65a
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
bbeb65a to
56a86a5
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
56a86a5 to
bbdb9f8
Compare
barbados-clemens
requested review from
FrozenPandaz,
vsavkin and
a team
as code owners
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
bbdb9f8 to
093d1a7
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
093d1a7 to
5462a66
Compare
xiongemi
reviewed
Jul 19, 2023
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
5462a66 to
0e54d19
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
0e54d19 to
4e108a0
Compare
jaysoo
reviewed
Jul 24, 2023
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
e45dafa to
d2f4d5c
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
d2f4d5c to
8ebb331
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
8ebb331 to
04a7ad9
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
04a7ad9 to
1f312f2
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
1f312f2 to
addad39
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
addad39 to
a355260
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
a355260 to
1364671
Compare
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
1364671 to
976103e
Compare
Coly010
approved these changes
Jul 31, 2023
isaacplmann
approved these changes
Jul 31, 2023
AgentEnder
approved these changes
Aug 1, 2023
barbados-clemens
force-pushed
the
feat/playwright-angular
branch
from
976103e to
b38d931
Compare
FrozenPandaz
approved these changes
Aug 2, 2023
| @@ -74,5 +74,5 @@ | |||
| }, | |||
| "lint": {} | |||
| }, | |||
| "implicitDependencies": ["workspace", "cypress", "jest"] | |||
| "implicitDependencies": ["workspace", "playwright", "cypress", "jest"] | |||
There was a problem hiding this comment.
See if these implicitDependencies are really needed.
| @@ -198,9 +198,20 @@ async function addE2ETestRunner( | |||
| ): Promise<GeneratorCallback> { | |||
| switch (options.e2eTestRunner) { | |||
| case E2eTestRunner.Cypress: | |||
| const { cypressInitGenerator } = ensurePackage< | |||
There was a problem hiding this comment.
Remove this because cypress is installed
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked By: #18190 and #18202
Current Behavior
angular app generator only support cypress|none.
Expected Behavior
angular app generator supports playwright|cypress|none
Related Issue(s)
Fixes #