Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): run build in watch mode when specified for faster recompile time #18145

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jul 17, 2023

When supported, run the build executor in watch mode so recompiles are faster. This works with our executors (e.g. webpack, vite, tsc, etc.), but custom executors (e.g. run-commands) should consider using runBuildTargetDependencies option for correctness.

Current Behavior

Recompiles are slow

Expected Behavior

Recompiles are faster

Related Issue(s)

Fixes #17070

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 5:25pm

@jaysoo jaysoo marked this pull request as ready for review July 17, 2023 15:31
@jaysoo jaysoo requested a review from a team as a code owner July 17, 2023 15:31
@jaysoo jaysoo requested a review from AgentEnder July 17, 2023 15:31
@nx-cloud
Copy link

nx-cloud bot commented Jul 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 51d1629. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ibockowsky
Copy link

This probably breaks Nestjs Instance with schema first approach. Apps reloading after every run

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

> NX File change detected. Restarting...
3 participants