Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): run ensurePackage with node_modules for yarn berry #18144

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

meeroslav
Copy link
Contributor

This PR ensures that the temp folder is created with node_modules linker for Yarn Berry when running ensurePackage.
This fixes the linking node modules before running require.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav self-assigned this Jul 17, 2023
@meeroslav meeroslav requested a review from a team as a code owner July 17, 2023 15:29
@meeroslav meeroslav requested a review from vsavkin July 17, 2023 15:29
@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 3:33pm

@nx-cloud
Copy link

nx-cloud bot commented Jul 17, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7fa5713. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants